From 708e8a7983470a2e354bb79f2b75a53c2e1be59e Mon Sep 17 00:00:00 2001 From: isharasampath Date: Thu, 19 Mar 2020 18:43:59 +0530 Subject: [PATCH] Added review comments. --- NTPClient.cpp | 4 ++-- NTPClient.h | 6 +++--- keywords.txt | 2 ++ 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/NTPClient.cpp b/NTPClient.cpp index b1e6763..23c03f1 100755 --- a/NTPClient.cpp +++ b/NTPClient.cpp @@ -153,12 +153,12 @@ DateTime NTPClient::getDateTime() const { return dt; } -String NTPClient::formatDateTime(const char* fmt) const { +String NTPClient::getFormattedDateTime(const char* dateTimeFormat) const { struct tm * ts; time_t rawTime = this->getEpochTime(); ts = localtime(&rawTime); char buf[64]; - strftime(buf, sizeof(buf), fmt, ts); + strftime(buf, sizeof(buf), dateTimeFormat, ts); return String(buf); } diff --git a/NTPClient.h b/NTPClient.h index 76d9e3e..638b449 100755 --- a/NTPClient.h +++ b/NTPClient.h @@ -85,15 +85,15 @@ class NTPClient { int getSeconds() const; /** - * Get date time as a astuct which contains + * Get date time as a struct which contains * Year, Month, Date, Hours, Minutes, Seconds */ DateTime getDateTime() const; /** - * Format the date time to a string with a given format (Ex: %Y/%m/%d %H:%M:%S) + * Return the date time as a String with the given format (Ex: %Y/%m/%d %H:%M:%S) */ - String formatDateTime(const char* fmt) const; + String getFormattedDateTime(const char* dateTimeFormat) const; /** * Changes the time offset. Useful for changing timezones dynamically diff --git a/keywords.txt b/keywords.txt index 6f7bc6f..0a0a366 100644 --- a/keywords.txt +++ b/keywords.txt @@ -21,3 +21,5 @@ getEpochTime KEYWORD2 setTimeOffset KEYWORD2 setUpdateInterval KEYWORD2 setPoolServerName KEYWORD2 +getDateTime KEYWORD2 +getFormattedDateTime KEYWORD2