lba.gitea/WLED
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

limit max. selectable preset ID to 250, according to WLED capabilities

Browse Source
This commit is contained in:
strikeout 2023-03-17 13:40:21 +01:00
parent de4ff4e58d
commit 56a854ec88
1 changed files with 22 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
wled00/e131.cpp
View File

@ -173,16 +173,21 @@ void handleE131Packet(e131_packet_t* p, IPAddress clientIP, byte protocol){
break; break;
case DMX_MODE_PRESET: // 2 channel: [Dimmer,Preset] case DMX_MODE_PRESET: // 2 channel: [Dimmer,Preset]
{
if (uni != e131Universe || availDMXLen < 2) return; if (uni != e131Universe || availDMXLen < 2) return;
// limit max. selectable preset to 250, even though DMX max. val is 255
uint8_t dmxValPreset = (e131_data[dataOffset+1] > 250 ? 250 : e131_data[dataOffset+1]);
// only apply preset if value changed // only apply preset if value changed
if (currentPreset != e131_data[dataOffset+1] && e131_data[dataOffset+1] != 0 && if (dmxValPreset != 0 && dmxValPreset != currentPreset &&
// only apply preset if not in playlist, or playlist changed // only apply preset if not in playlist, or playlist changed
(currentPlaylist < 0 || currentPlaylist != e131_data[dataOffset+1])) { (currentPlaylist < 0 || dmxValPreset != currentPlaylist)) {
presetCycCurr = e131_data[dataOffset+1]; presetCycCurr = dmxValPreset;
unloadPlaylist(); // applying a preset unloads the playlist unloadPlaylist(); // applying a preset unloads the playlist
applyPreset(e131_data[dataOffset+1], CALL_MODE_NOTIFICATION); applyPreset(dmxValPreset, CALL_MODE_NOTIFICATION);
} }
// only change brightness if value changed // only change brightness if value changed
if (bri != e131_data[dataOffset]) { if (bri != e131_data[dataOffset]) {
bri = e131_data[dataOffset]; bri = e131_data[dataOffset];
@ -191,6 +196,7 @@ void handleE131Packet(e131_packet_t* p, IPAddress clientIP, byte protocol){
} }
return; return;
break; break;
}
case DMX_MODE_EFFECT: // 15 channels [bri,effectCurrent,effectSpeed,effectIntensity,effectPalette,effectOption,R,G,B,R2,G2,B2,R3,G3,B3] case DMX_MODE_EFFECT: // 15 channels [bri,effectCurrent,effectSpeed,effectIntensity,effectPalette,effectOption,R,G,B,R2,G2,B2,R3,G3,B3]
case DMX_MODE_EFFECT_W: // 18 channels, same as above but with extra +3 white channels [..,W,W2,W3] case DMX_MODE_EFFECT_W: // 18 channels, same as above but with extra +3 white channels [..,W,W2,W3]