lba.gitea/WLED
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Change parameter order for better stack alignment

Browse Source
This commit is contained in:
Phil Bolduc 2021-09-19 15:30:17 -07:00
parent 6472d35d91
commit 7dc07f6d21
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
wled00/DDP.cpp
View File

@ -57,15 +57,15 @@ uint8_t* copyRgbwToRgb(uint8_t *destination, uint8_t *source, uint16_t length) {
// Send real time DDP UDP updates to the specified client // Send real time DDP UDP updates to the specified client
// //
// client - the IP address to send to // client - the IP address to send to
// busLength - the number of pixels // length - the number of pixels
// rgbwData - a buffer of at least busLength*4 bytes long // rgbwData - a buffer of at least length*4 bytes long
// //
uint8_t realtimeBrodacast(IPAddress client, uint16_t busLength, uint8_t *rgbwData) { uint8_t realtimeBrodacast(IPAddress client, uint8_t *rgbwData, uint16_t length) {
WiFiUDP ddpUdp; WiFiUDP ddpUdp;
// calclate the number of UDP packets we need to send // calclate the number of UDP packets we need to send
uint16_t channelCount = busLength * 3; uint16_t channelCount = length * 3; // 1 channel for every R,G,B value
uint16_t packetCount = channelCount / DDP_CHANNELS_PER_PACKET; uint16_t packetCount = channelCount / DDP_CHANNELS_PER_PACKET;
if (channelCount % DDP_CHANNELS_PER_PACKET) { if (channelCount % DDP_CHANNELS_PER_PACKET) {
packetCount++; packetCount++;
@ -73,7 +73,7 @@ uint8_t realtimeBrodacast(IPAddress client, uint16_t busLength, uint8_t *rgbwDat
// allocate a buffer for the UDP packet // allocate a buffer for the UDP packet
size_t bufferSize = (DDP_HEADER_LEN + DDP_CHANNELS_PER_PACKET) * sizeof(uint8_t); size_t bufferSize = (DDP_HEADER_LEN + DDP_CHANNELS_PER_PACKET) * sizeof(uint8_t);
uint8_t* buffer = (byte*)malloc(bufferSize); uint8_t* buffer = (uint8_t*)malloc(bufferSize);
if (!buffer) { if (!buffer) {
return 1; return 1;
} }
@ -86,12 +86,7 @@ uint8_t realtimeBrodacast(IPAddress client, uint16_t busLength, uint8_t *rgbwDat
buffer[3] = DDP_ID_DISPLAY; buffer[3] = DDP_ID_DISPLAY;
// there are 3 channels per RGB pixel // there are 3 channels per RGB pixel
int channel = 0; // TODO: allow specifying the start channel uint16_t channel = 0; // TODO: allow specifying the start channel
// if we need to split
//
//
for (uint16_t currentPacket = 0; currentPacket < packetCount; currentPacket++) { for (uint16_t currentPacket = 0; currentPacket < packetCount; currentPacket++) {