From b694bcf62a7e199ceb060612eac10a1ec0a1d7ac Mon Sep 17 00:00:00 2001
From: Hermann Kraus <hermr2d2+git@gmail.com>
Date: Sun, 1 Nov 2020 02:23:37 +0100
Subject: [PATCH] Fix MQTT topic parsing.

The previous code only looked for certain keywords in the topic instead of comparing it completely.
For example if mqttDeviceTopic is set to "lights/colorRGB" the MQTT interface is unusable because
the search for "/col" will always return a match and therefore any MQTT command is interpreted as
a color.
The new code checks the full topic.
---
 wled00/mqtt.cpp | 24 ++++++++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/wled00/mqtt.cpp b/wled00/mqtt.cpp
index 46f49e19..546d9d06 100644
--- a/wled00/mqtt.cpp
+++ b/wled00/mqtt.cpp
@@ -64,18 +64,34 @@ void onMqttMessage(char* topic, char* payload, AsyncMqttClientMessageProperties
   }
   DEBUG_PRINTLN(payload);
 
-  //no need to check the topic because we only get topics we are subscribed to
+  size_t topicPrefixLen = strlen(mqttDeviceTopic);
+  if (strncmp(topic, mqttDeviceTopic, topicPrefixLen) == 0) {
+      topic += topicPrefixLen;
+  } else {
+      size_t topic_prefix_len = strlen(mqttGroupTopic);
+      if (strncmp(topic, mqttGroupTopic, topicPrefixLen) == 0) {
+          topic += topicPrefixLen;
+      } else {
+          // Topic not used here. Probably a usermod subscribed to this topic.
+          return;
+      }
+  }
 
-  if (strstr(topic, "/col"))
+  //Prefix is stripped from the topic at this point
+
+  if (strcmp(topic, "/col") == 0)
   {
     colorFromDecOrHexString(col, (char*)payload);
     colorUpdated(NOTIFIER_CALL_MODE_DIRECT_CHANGE);
-  } else if (strstr(topic, "/api"))
+  } else if (strcmp(topic, "/api") == 0)
   {
     String apireq = "win&";
     apireq += (char*)payload;
     handleSet(nullptr, apireq);
-  } else parseMQTTBriPayload(payload);
+  } else if (strcmp(topic, "") == 0)
+  {
+      parseMQTTBriPayload(payload);
+  }
 }