From 12de47c923b8ff86e8c029695ae61c85a4d0018f Mon Sep 17 00:00:00 2001 From: Def3nder Date: Fri, 16 Apr 2021 10:22:22 +0200 Subject: [PATCH 1/3] Fix TV-Simmulator Effect flash usage (#1621) * Add alternative TV-Sim version without tv_colors.h ...and safe 18k flash this way * ...remove the define --- wled00/FX.cpp | 131 +++++++++++++++++++++++++++++++++++++++----------- 1 file changed, 102 insertions(+), 29 deletions(-) diff --git a/wled00/FX.cpp b/wled00/FX.cpp index d64e6f80..c5df495d 100644 --- a/wled00/FX.cpp +++ b/wled00/FX.cpp @@ -25,7 +25,6 @@ */ #include "FX.h" -#include "tv_colors.h" #define IBN 5100 #define PALETTE_SOLID_WRAP (paletteBlend == 1 || paletteBlend == 3) @@ -3832,19 +3831,30 @@ uint16_t WS2812FX::mode_blends(void) { return FRAMETIME; } -#ifndef WLED_DISABLE_FX_HIGH_FLASH_USE typedef struct TvSim { uint32_t totalTime = 0; uint32_t fadeTime = 0; uint32_t startTime = 0; uint32_t elapsed = 0; uint32_t pixelNum = 0; + uint16_t sliderValues = 0; + uint32_t sceeneStart = 0; + uint32_t sceeneDuration = 0; + uint16_t sceeneColorHue = 0; + uint8_t sceeneColorSat = 0; + uint8_t sceeneColorBri = 0; + uint8_t actualColorR = 0; + uint8_t actualColorG = 0; + uint8_t actualColorB = 0; uint16_t pr = 0; // Prev R, G, B uint16_t pg = 0; uint16_t pb = 0; } tvSim; -#define numTVPixels (sizeof(tv_colors) / 2) // 2 bytes per Pixel (5/6/5) + +#ifndef WLED_DISABLE_FX_HIGH_FLASH_USE + #include "tv_colors.h" + #define numTVPixels (sizeof(tv_colors) / 2) // 2 bytes per Pixel (5/6/5) #endif /* @@ -3852,45 +3862,109 @@ typedef struct TvSim { Modified and adapted to WLED by Def3nder, based on "Fake TV Light for Engineers" by Phillip Burgess https://learn.adafruit.com/fake-tv-light-for-engineers/arduino-sketch */ uint16_t WS2812FX::mode_tv_simulator(void) { - #ifdef WLED_DISABLE_FX_HIGH_FLASH_USE - return mode_static(); - #else - uint16_t nr, ng, nb, r, g, b, i; - uint8_t hi, lo, r8, g8, b8; + uint16_t nr, ng, nb, r, g, b, i, hue; + uint8_t hi, lo, r8, g8, b8, sat, bri, j; if (!SEGENV.allocateData(sizeof(tvSim))) return mode_static(); //allocation failed TvSim* tvSimulator = reinterpret_cast(SEGENV.data); - // initialize start of the TV-Colors - if (SEGENV.call == 0) { - tvSimulator->pixelNum = ((uint8_t)random(18)) * numTVPixels / 18; // Begin at random movie (18 in total) + uint8_t colorSpeed = map(SEGMENT.speed, 0, UINT8_MAX, 1, 20); + uint8_t colorIntensity = map(SEGMENT.intensity, 0, UINT8_MAX, 10, 30); + + i = SEGMENT.speed << 8 | SEGMENT.intensity; + if (i != tvSimulator->sliderValues) { + tvSimulator->sliderValues = i; + SEGENV.aux1 = 0; } - // Read next 16-bit (5/6/5) color - hi = pgm_read_byte(&tv_colors[tvSimulator->pixelNum * 2 ]); - lo = pgm_read_byte(&tv_colors[tvSimulator->pixelNum * 2 + 1]); + #ifndef WLED_DISABLE_FX_HIGH_FLASH_USE + /* + * this code uses the real color data from tv_colos.h + */ - // Expand to 24-bit (8/8/8) - r8 = (hi & 0xF8) | (hi >> 5); - g8 = ((hi << 5) & 0xff) | ((lo & 0xE0) >> 3) | ((hi & 0x06) >> 1); - b8 = ((lo << 3) & 0xff) | ((lo & 0x1F) >> 2); + // initialize start of the TV-Colors + if (SEGENV.aux1 == 0) { + tvSimulator->pixelNum = ((uint8_t)random8(18)) * numTVPixels / 18; // Begin at random movie (18 in total) + SEGENV.aux1 = 1; + } + + // Read next 16-bit (5/6/5) color + hi = pgm_read_byte(&tv_colors[tvSimulator->pixelNum * 2 ]); + lo = pgm_read_byte(&tv_colors[tvSimulator->pixelNum * 2 + 1]); + + // Expand to 24-bit (8/8/8) + r8 = (hi & 0xF8) | (hi >> 5); + g8 = ((hi << 5) & 0xff) | ((lo & 0xE0) >> 3) | ((hi & 0x06) >> 1); + b8 = ((lo << 3) & 0xff) | ((lo & 0x1F) >> 2); - // Apply gamma correction, further expand to 16/16/16 - nr = (uint8_t)gamma8(r8) * 257; // New R/G/B - ng = (uint8_t)gamma8(g8) * 257; - nb = (uint8_t)gamma8(b8) * 257; + // Apply gamma correction, further expand to 16/16/16 + nr = (uint8_t)gamma8(r8) * 257; // New R/G/B + ng = (uint8_t)gamma8(g8) * 257; + nb = (uint8_t)gamma8(b8) * 257; + #else + /* + * this code calculates the color to be used and save 18k of flash memory + */ + + // create a new sceene + if (((millis() - tvSimulator->sceeneStart) >= tvSimulator->sceeneDuration) || SEGENV.aux1 == 0) { + tvSimulator->sceeneStart = millis(); // remember the start of the new sceene + tvSimulator->sceeneDuration = random16(60* 250* colorSpeed, 60* 750 * colorSpeed); // duration of a "movie sceene" which has similar colors (5 to 15 minutes with max speed slider) + tvSimulator->sceeneColorHue = random16( 0, 768); // random start color-tone for the sceene + tvSimulator->sceeneColorSat = random8 ( 100, 130 + colorIntensity); // random start color-saturation for the sceene + tvSimulator->sceeneColorBri = random8 ( 200, 240); // random start color-brightness for the sceene + SEGENV.aux1 = 1; + SEGENV.aux0 = 0; + } + + // slightly change the color-tone in this sceene + if ( SEGENV.aux0 == 0) { + // hue change in both directions + j = random8(4 * colorIntensity); + hue = (random8() < 128) ? ((j < tvSimulator->sceeneColorHue) ? tvSimulator->sceeneColorHue - j : 767 - tvSimulator->sceeneColorHue - j) : // negative + ((j + tvSimulator->sceeneColorHue) < 767 ? tvSimulator->sceeneColorHue + j : tvSimulator->sceeneColorHue + j - 767) ; // positive + + // saturation + j = random8(2 * colorIntensity); + sat = (tvSimulator->sceeneColorSat - j) < 0 ? 0 : tvSimulator->sceeneColorSat - j; + + // brightness + j = random8(100); + bri = (tvSimulator->sceeneColorBri - j) < 0 ? 0 : tvSimulator->sceeneColorBri - j; + + // calculate R,G,B from HSV + // Source: https://blog.adafruit.com/2012/03/14/constant-brightness-hsb-to-rgb-algorithm/ + { // just to create a local scope for the variables + uint8_t temp[5], n = (hue >> 8) % 3; + uint8_t x = ((((hue & 255) * sat) >> 8) * bri) >> 8; + uint8_t s = ( (256 - sat) * bri) >> 8; + temp[0] = temp[3] = s; + temp[1] = temp[4] = x + s; + temp[2] = bri - x; + tvSimulator->actualColorR = temp[n + 2]; + tvSimulator->actualColorG = temp[n + 1]; + tvSimulator->actualColorB = temp[n ]; + } + } + // Apply gamma correction, further expand to 16/16/16 + nr = (uint8_t)gamma8(tvSimulator->actualColorR) * 257; // New R/G/B + ng = (uint8_t)gamma8(tvSimulator->actualColorG) * 257; + nb = (uint8_t)gamma8(tvSimulator->actualColorB) * 257; + #endif if (SEGENV.aux0 == 0) { // initialize next iteration SEGENV.aux0 = 1; - // increase color-index for next loop - tvSimulator->pixelNum++; - if (tvSimulator->pixelNum >= numTVPixels) tvSimulator->pixelNum = 0; + #ifndef WLED_DISABLE_FX_HIGH_FLASH_USE + // increase color-index for next loop + tvSimulator->pixelNum++; + if (tvSimulator->pixelNum >= numTVPixels) tvSimulator->pixelNum = 0; + #endif // randomize total duration and fade duration for the actual color - tvSimulator->totalTime = random(250, 2500); // Semi-random pixel-to-pixel time - tvSimulator->fadeTime = random(0, tvSimulator->totalTime); // Pixel-to-pixel transition time - if (random(10) < 3) tvSimulator->fadeTime = 0; // Force scene cut 30% of time + tvSimulator->totalTime = random16(250, 2500); // Semi-random pixel-to-pixel time + tvSimulator->fadeTime = random16(0, tvSimulator->totalTime); // Pixel-to-pixel transition time + if (random8(10) < 3) tvSimulator->fadeTime = 0; // Force scene cut 30% of time tvSimulator->startTime = millis(); } // end of initialization @@ -3923,7 +3997,6 @@ uint16_t WS2812FX::mode_tv_simulator(void) { } return FRAMETIME; - #endif } /* From 13e5c695c3bb96af05420ca4348c1f8314f3eccd Mon Sep 17 00:00:00 2001 From: Eric Severance Date: Sun, 18 Apr 2021 10:14:12 -0700 Subject: [PATCH 2/3] Initialize PixelSettings for TM1814 strips (#1847) * Better handling for TM1814 strips * Call SetPixelSettings after Begin as described on the NeoPixelBus wiki * Use NeoTm1814Settings::MaxCurrent constant --- wled00/bus_wrapper.h | 49 ++++++++++++++++++++++++++++---------------- 1 file changed, 31 insertions(+), 18 deletions(-) diff --git a/wled00/bus_wrapper.h b/wled00/bus_wrapper.h index c96896c3..bd3da14d 100644 --- a/wled00/bus_wrapper.h +++ b/wled00/bus_wrapper.h @@ -28,7 +28,7 @@ #define I_8266_U1_400_3 10 #define I_8266_DM_400_3 11 #define I_8266_BB_400_3 12 -//TM1418 (RGBW) +//TM1814 (RGBW) #define I_8266_U0_TM1_4 13 #define I_8266_U1_TM1_4 14 #define I_8266_DM_TM1_4 15 @@ -68,7 +68,7 @@ #define I_32_R7_400_3 44 #define I_32_I0_400_3 45 #define I_32_I1_400_3 46 -//TM1418 (RGBW) +//TM1814 (RGBW) #define I_32_R0_TM1_4 47 #define I_32_R1_TM1_4 48 #define I_32_R2_TM1_4 49 @@ -115,7 +115,7 @@ #define B_8266_U1_400_3 NeoPixelBrightnessBus //3 chan, esp8266, gpio2 #define B_8266_DM_400_3 NeoPixelBrightnessBus //3 chan, esp8266, gpio3 #define B_8266_BB_400_3 NeoPixelBrightnessBus //3 chan, esp8266, bb (any pin) -//TM1418 (RGBW) +//TM1814 (RGBW) #define B_8266_U0_TM1_4 NeoPixelBrightnessBus #define B_8266_U1_TM1_4 NeoPixelBrightnessBus #define B_8266_DM_TM1_4 NeoPixelBrightnessBus @@ -157,7 +157,7 @@ #define B_32_R7_400_3 NeoPixelBrightnessBus #define B_32_I0_400_3 NeoPixelBrightnessBus #define B_32_I1_400_3 NeoPixelBrightnessBus -//TM1418 (RGBW) +//TM1814 (RGBW) #define B_32_R0_TM1_4 NeoPixelBrightnessBus #define B_32_R1_TM1_4 NeoPixelBrightnessBus #define B_32_R2_TM1_4 NeoPixelBrightnessBus @@ -191,6 +191,15 @@ //handles pointer type conversion for all possible bus types class PolyBus { public: + // Begin & initialize the PixelSettings for TM1814 strips. + template + static void beginTM1814(void* busPtr) { + T tm1814_strip = static_cast(busPtr); + tm1814_strip->Begin(); + // Max current for each LED (38.0 mA). + const uint16_t max = NeoTm1814Settings::MaxCurrent; + tm1814_strip->SetPixelSettings(NeoTm1814Settings(/*R*/max, /*G*/max, /*B*/max, /*W*/max)); + } static void begin(void* busPtr, uint8_t busType, uint8_t* pins) { switch (busType) { case I_NONE: break; @@ -207,10 +216,10 @@ class PolyBus { case I_8266_U1_400_3: (static_cast(busPtr))->Begin(); break; case I_8266_DM_400_3: (static_cast(busPtr))->Begin(); break; case I_8266_BB_400_3: (static_cast(busPtr))->Begin(); break; - case I_8266_U0_TM1_4: (static_cast(busPtr))->Begin(); break; - case I_8266_U1_TM1_4: (static_cast(busPtr))->Begin(); break; - case I_8266_DM_TM1_4: (static_cast(busPtr))->Begin(); break; - case I_8266_BB_TM1_4: (static_cast(busPtr))->Begin(); break; + case I_8266_U0_TM1_4: beginTM1814(busPtr); break; + case I_8266_U1_TM1_4: beginTM1814(busPtr); break; + case I_8266_DM_TM1_4: beginTM1814(busPtr); break; + case I_8266_BB_TM1_4: beginTM1814(busPtr); break; case I_HS_DOT_3: (static_cast(busPtr))->Begin(); break; case I_HS_LPD_3: (static_cast(busPtr))->Begin(); break; case I_HS_WS1_3: (static_cast(busPtr))->Begin(); break; @@ -247,16 +256,16 @@ class PolyBus { case I_32_R7_400_3: (static_cast(busPtr))->Begin(); break; case I_32_I0_400_3: (static_cast(busPtr))->Begin(); break; case I_32_I1_400_3: (static_cast(busPtr))->Begin(); break; - case I_32_R0_TM1_4: (static_cast(busPtr))->Begin(); break; - case I_32_R1_TM1_4: (static_cast(busPtr))->Begin(); break; - case I_32_R2_TM1_4: (static_cast(busPtr))->Begin(); break; - case I_32_R3_TM1_4: (static_cast(busPtr))->Begin(); break; - case I_32_R4_TM1_4: (static_cast(busPtr))->Begin(); break; - case I_32_R5_TM1_4: (static_cast(busPtr))->Begin(); break; - case I_32_R6_TM1_4: (static_cast(busPtr))->Begin(); break; - case I_32_R7_TM1_4: (static_cast(busPtr))->Begin(); break; - case I_32_I0_TM1_4: (static_cast(busPtr))->Begin(); break; - case I_32_I1_TM1_4: (static_cast(busPtr))->Begin(); break; + case I_32_R0_TM1_4: beginTM1814(busPtr); break; + case I_32_R1_TM1_4: beginTM1814(busPtr); break; + case I_32_R2_TM1_4: beginTM1814(busPtr); break; + case I_32_R3_TM1_4: beginTM1814(busPtr); break; + case I_32_R4_TM1_4: beginTM1814(busPtr); break; + case I_32_R5_TM1_4: beginTM1814(busPtr); break; + case I_32_R6_TM1_4: beginTM1814(busPtr); break; + case I_32_R7_TM1_4: beginTM1814(busPtr); break; + case I_32_I0_TM1_4: beginTM1814(busPtr); break; + case I_32_I1_TM1_4: beginTM1814(busPtr); break; // ESP32 can (and should, to avoid inadvertantly driving the chip select signal) specify the pins used for SPI, but only in begin() case I_HS_DOT_3: (static_cast(busPtr))->Begin(pins[1], -1, pins[0], -1); break; case I_HS_LPD_3: (static_cast(busPtr))->Begin(pins[1], -1, pins[0], -1); break; @@ -860,6 +869,8 @@ class PolyBus { return I_8266_U0_NEO_4 + offset; case TYPE_WS2811_400KHZ: return I_8266_U0_400_3 + offset; + case TYPE_TM1814: + return I_8266_U0_TM1_4 + offset; } #else //ESP32 uint8_t offset = num; //RMT bus # == bus index in BusManager @@ -872,6 +883,8 @@ class PolyBus { return I_32_R0_NEO_4 + offset; case TYPE_WS2811_400KHZ: return I_32_R0_400_3 + offset; + case TYPE_TM1814: + return I_32_R0_TM1_4 + offset; } #endif } From eb99271120b52356699546f08a9c57fffddd4ab4 Mon Sep 17 00:00:00 2001 From: Eric Severance Date: Tue, 20 Apr 2021 12:36:52 -0700 Subject: [PATCH 3/3] Use 22.5 for the TM1814 max current (#1905) * Configure TM1814 max current * Use 22.5 mA as this seems to be a common value for the LEDs --- wled00/bus_wrapper.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/wled00/bus_wrapper.h b/wled00/bus_wrapper.h index bd3da14d..e5e5db54 100644 --- a/wled00/bus_wrapper.h +++ b/wled00/bus_wrapper.h @@ -196,9 +196,8 @@ class PolyBus { static void beginTM1814(void* busPtr) { T tm1814_strip = static_cast(busPtr); tm1814_strip->Begin(); - // Max current for each LED (38.0 mA). - const uint16_t max = NeoTm1814Settings::MaxCurrent; - tm1814_strip->SetPixelSettings(NeoTm1814Settings(/*R*/max, /*G*/max, /*B*/max, /*W*/max)); + // Max current for each LED (22.5 mA). + tm1814_strip->SetPixelSettings(NeoTm1814Settings(/*R*/225, /*G*/225, /*B*/225, /*W*/225)); } static void begin(void* busPtr, uint8_t busType, uint8_t* pins) { switch (busType) {